Changeset 1054

Timestamp:

09/09/07 15:35:12 (15 months ago)

Author:

wichert

Message:

Reuse the packet construction class for auth and acct packets

Files:

• trunk/pyrad/tests/testPacket.py (modified) (6 diffs)

trunk/pyrad/tests/testPacket.py

@@ -16 +16 @@
 
 class PacketConstructionTests(unittest.TestCase):
+    klass = packet.Packet
 
     def setUp(self):
@@ -23 +24 @@
 
     def testBasicConstructor(self):
-        pkt=packet.Packet()
+        pkt=self.klass()
         self.failUnless(isinstance(pkt.code, int))
         self.failUnless(isinstance(pkt.id, int))
@@ -30 +31 @@
 
     def testNamedConstructor(self):
-        pkt=packet.Packet(code=26, id=38, secret="secret",
+        pkt=self.klass(code=26, id=38, secret="secret",
                 authenticator="authenticator",
                 dict="fakedict")
@@ -41 +42 @@
 
     def testConstructWithDictionary(self):
-        pkt=packet.Packet(dict=self.dict)
+        pkt=self.klass(dict=self.dict)
         self.failUnless(pkt.dict is self.dict)
 
@@ -47 +48 @@
     def testConstructorIgnoredParameters(self):
         marker=[]
-        pkt=packet.Packet(fd=marker)
+        pkt=self.klass(fd=marker)
         self.failIf(getattr(pkt, "fd", None) is marker)
 
 
     def testConstructorWithAttributes(self):
-        pkt=packet.Packet(dict=self.dict, Test_String="this works")
+        pkt=self.klass(dict=self.dict, Test_String="this works")
         self.assertEqual(pkt["Test-String"], ["this works"])
 
@@ -284 +285 @@
         self.assertEqual(self.packet[26], ["value"])
 
+
+class AuthPacketConstructionTests(PacketConstructionTests):
+    klass = packet.AuthPacket
+
+    def testConstructorDefaults(self):
+        pkt=self.klass()
+        self.assertEqual(pkt.code, packet.AccessRequest)
+
+
+class AcctPacketConstructionTests(PacketConstructionTests):
+    klass = packet.AcctPacket
+
+    def testConstructorDefaults(self):
+        pkt=self.klass()
+        self.assertEqual(pkt.code, packet.AccountingRequest)
+