Changeset 1039

Timestamp:

09/03/07 00:40:31 (15 months ago)

Author:

wichert

Message:

More tests. Found our second bug so far: setting raw attributes did not work due to a bad assertion

Location:

trunk/pyrad

Files:

• packet.py (modified) (1 diff)
• tests/testPacket.py (modified) (3 diffs)

trunk/pyrad/packet.py

@@ -181 +181 @@
                         self.data[key]=item
                 else:
-                        assert(type(item)==types.ListType)
-                        self.data[key]=[item]
+                        assert isinstance(item, list)
+                        self.data[key]=item
 
 

trunk/pyrad/tests/testPacket.py

@@ -76 +76 @@
         self.packet["Test-Integer"]=10
         self.assertEqual(self.packet["Test-Integer"], [10])
-        self.assertEqual(self.packet[3], [10])
+        self.assertEqual(self.packet[3], ["\x00\x00\x00\x0a"])
 
         self.packet["Test-String"]="dummy"
@@ -86 +86 @@
         self.packet["Test-Integer"]="Three"
         self.assertEqual(self.packet["Test-Integer"], ["Three"])
+        self.assertEqual(self.packet[3], ["\x00\x00\x00\x03"])
 
 
@@ -91 +92 @@
         self.packet["Simplon-Number"]=10
         self.assertEqual(self.packet["Simplon-Number"], [10])
+        self.assertEqual(self.packet[(16,1)], ["\x00\x00\x00\x0a"])
 
         self.packet["Simplon-Number"]="Four"
         self.assertEqual(self.packet["Simplon-Number"], ["Four"])
+        self.assertEqual(self.packet[(16,1)], ["\x00\x00\x00\x04"])
+
+    def testRawAttributeAccess(self):
+        marker=[""]
+        self.packet[1]=marker
+        self.failUnless(self.packet[1] is marker)
+        self.assertEqual(self.packet["Test-String"], marker)
+
+        self.packet[(16,1)]=marker
+        self.failUnless(self.packet[(16,1)] is marker)